Skip to content

feat: add typing stub for redirectError#24062

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
VadimLevin:dev/vlevin/python-typing-redirect-error
Jul 27, 2023
Merged

feat: add typing stub for redirectError#24062
asmorkalov merged 1 commit intoopencv:4.xfrom
VadimLevin:dev/vlevin/python-typing-redirect-error

Conversation

@VadimLevin
Copy link
Copy Markdown
Contributor

redirectError is defined in cv2_util.cpp and manually exported in cv2.cpp

Python interface for redirectError:

def redirectError(
    onError: Callable[[int, str, str, str, int], None] | None
) -> None: ...

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

@VadimLevin please reabase and fix conflicts.

Python interface for `redirectError`:

```python
def redirectError(
    onError: Callable[[int, str, str, str, int], None] | None
) -> None: ...
```
@VadimLevin VadimLevin force-pushed the dev/vlevin/python-typing-redirect-error branch from 76debba to e59b8cd Compare July 26, 2023 18:36
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 5c090b9 into opencv:4.x Jul 27, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants