Skip to content

fix compilation error on Windows ARM, use vaddq_f32 instead of +=#24043

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
zixianwei01:use-vaddq_f32-on-arm64
Jul 25, 2023
Merged

fix compilation error on Windows ARM, use vaddq_f32 instead of +=#24043
asmorkalov merged 1 commit intoopencv:4.xfrom
zixianwei01:use-vaddq_f32-on-arm64

Conversation

@zixianwei01
Copy link
Copy Markdown
Contributor

@zixianwei01 zixianwei01 commented Jul 21, 2023

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@opencv-alalek opencv-alalek added bug optimization category: dnn platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc labels Jul 22, 2023
zihaomu
zihaomu approved these changes Jul 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@asmorkalov asmorkalov mentioned this pull request Jul 25, 2023
Closed
4 tasks
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 25, 2023

Tested build only. MSVS 2022 with ARM64 toolchain installed. CMake toolchain used:

set(CMAKE_CROSSCOMPILING 1)
set(CMAKE_SYSTEM_NAME Windows)
set(CMAKE_SYSTEM_PROCESSOR ARM64)
set(CMAKE_SYSTEM_VERSION 10.0)

set(CMAKE_GENERATOR_PLATFORM ARM64 CACHE INTERNAL "")

set(CMAKE_C_COMPILER "C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/arm/cl.exe")
set(CMAKE_CXX_COMPILER "C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/arm/cl.exe")
set(CMAKE_ASM_COMPILER "C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/arm/cl.exe")

@asmorkalov asmorkalov self-requested a review July 25, 2023 08:40
asmorkalov
asmorkalov approved these changes Jul 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit e5e1a3b into opencv:4.x Jul 25, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@zihaomu zihaomu zihaomu approved these changes

Assignees

@zihaomu zihaomu

Labels

bug category: dnn optimization platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zixianwei01 @asmorkalov @zihaomu @opencv-alalek