Skip to content

test_houghlines: Fix C++20 compatibility#24008

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
iarspider:patch-1
Jul 18, 2023
Merged

test_houghlines: Fix C++20 compatibility#24008
asmorkalov merged 1 commit intoopencv:4.xfrom
iarspider:patch-1

Conversation

@iarspider
Copy link
Copy Markdown
Contributor

C++20 made it invalid to use simple-template-ids for constructors and destructors: https://eel.is/c++draft/diff.cpp17.class#2 GCC 11 and later throw an error on this, with the unhelpful message expected unqualified-id before ')' token. This PR fixes the problem.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

C++20 made it invalid to use simple-template-ids for constructors and destructors: https://eel.is/c++draft/diff.cpp17.class#2
GCC 11 and later throw an error on this, with the unhelpful message `expected unqualified-id before ')' token`. This PR fixes the problem.
@asmorkalov asmorkalov self-requested a review July 18, 2023 10:49
@asmorkalov asmorkalov self-assigned this Jul 18, 2023
@asmorkalov asmorkalov added this to the 4.9.0 milestone Jul 18, 2023
@asmorkalov asmorkalov changed the base branch from master to 4.x July 18, 2023 10:49
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 81f07f0 into opencv:4.x Jul 18, 2023
@iarspider iarspider deleted the patch-1 branch July 19, 2023 08:08
@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants