Merged
Conversation
asmorkalov
reviewed
Jul 18, 2023
| }; | ||
| class PnPSVDSolver : public MinimalSolver { | ||
| public: | ||
| static Ptr<PnPSVDSolver> create (const Mat &points); |
Contributor
Author
There was a problem hiding this comment.
there is PnPSVDSolver in 4.x, it's just on another line:
https://github.com/opencv/opencv/blob/4.x/modules/calib3d/src/usac.hpp#L97
Contributor
There was a problem hiding this comment.
Please use the same file structure and not swap classes to reduce merge conflicts.
Contributor
Author
There was a problem hiding this comment.
fixed this by moving all new stuff created in 5.x to the end of the file.
| // return maximum number of possible solutions of non-minimal estimation. | ||
| virtual int getMaxNumSolutionsNonMinimal () const = 0; | ||
| virtual Ptr<Estimator> clone() const = 0; | ||
| virtual void enforceRankConstraint (bool enforce) = 0; |
Contributor
There was a problem hiding this comment.
EssentialEstimator changes are missing.
93c33b0 to
aae8f86
Compare
asmorkalov
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Base branch is PR #23979. Merging PR #23078 and PR #23806 to 5.x