Skip to content

Use OpenCV logging instead of std::cerr#23999

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/opencv_logging
Jul 19, 2023
Merged

Use OpenCV logging instead of std::cerr#23999
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/opencv_logging

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Jul 17, 2023 •
edited
Loading

Address: #23994

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.9.0 milestone Jul 17, 2023
@asmorkalov asmorkalov requested a review from opencv-alalek July 17, 2023 09:51
dkurt
dkurt reviewed Jul 17, 2023
View reviewed changes
opencv-alalek
opencv-alalek reviewed Jul 19, 2023
View reviewed changes
modules/dnn/src/layers/max_unpooling_layer.cpp Outdated
<< "indices.size=" << indices.size << std::endl
<< "outBlob=" << outBlob.size << std::endl
;
CV_LOG_DEBUG(NULL, cv::format(
Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug logger messages are completely turned off in release builds by default (in compile time - no way to enable them in runtime).

It is detail message for the error below.

Copy link
Copy Markdown
Contributor Author

@asmorkalov asmorkalov Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! Replaced with CV_LOG_ERROR.

@asmorkalov asmorkalov merged commit b0cbd6e into opencv:4.x Jul 19, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

@opencv-alalek opencv-alalek opencv-alalek approved these changes

Assignees

@opencv-alalek opencv-alalek

Labels

category: build/install category: core category: dnn category: imgcodecs

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asmorkalov @dkurt @opencv-alalek