Skip to content

Update mat.inl.hpp to solve the warning C5054#23974

Closed
MRNath wants to merge 1 commit intoopencv:4.xfrom
MRNath:4.x
Closed

Update mat.inl.hpp to solve the warning C5054#23974
MRNath wants to merge 1 commit intoopencv:4.xfrom
MRNath:4.x

Conversation

@MRNath
Copy link
Copy Markdown

@MRNath MRNath commented Jul 12, 2023

use static_cast() to convert the ACCESS_RW,ACCESS_WRITE,ACCESS_Read that after the '+' to solve the waring C5054 in VS2022 c++20

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@MRNath
Update mat.inl.hpp to solve the warning C5054
ac2ad17 
use static_cast<int>() to convert the ACCESS_RW,ACCESS_WRITE,ACCESS_Read that after the '+' to solve the waring C5054 in VS2022 c++20
@asmorkalov asmorkalov requested a review from opencv-alalek July 12, 2023 06:46
@mshabunin
Copy link
Copy Markdown
Contributor

mshabunin commented Jul 12, 2023

This warning has been turned off for this file for clang compiler: see the beginning of the file (-Wdeprecated-enum-enum-conversion). Perhaps we can just disable it for MSVC too.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 14, 2023

Massive file modification makes it harder to read and causes merge conflicts between branches. Please replace it with warning supression pragma as it's already done there:

opencv/modules/core/include/opencv2/core/mat.inl.hpp

Line 54 in 1f7025f

#pragma warning( disable: 4127 )

@asmorkalov asmorkalov mentioned this pull request Jul 25, 2023
Merged
6 tasks
@asmorkalov asmorkalov closed this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek Awaiting requested review from opencv-alalek

Assignees

@opencv-alalek opencv-alalek

Labels

category: build/install category: core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MRNath @mshabunin @asmorkalov @opencv-alalek