Prefer using TYPE_CHECKING condition in cv2.typing module#23972
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Jul 12, 2023
Avasam:partially-unknown-mat
Merged
Prefer using TYPE_CHECKING condition in cv2.typing module#23972asmorkalov merged 1 commit intoopencv:4.xfrom Avasam:partially-unknown-mat
TYPE_CHECKING condition in cv2.typing module#23972asmorkalov merged 1 commit intoopencv:4.xfrom
Avasam:partially-unknown-mat
Conversation
Contributor
Author
|
CC @VadimLevin |
Avasam
commented
Jul 11, 2023
| # Same as cv2.typing.NumPyArrayGeneric, but avoids circular dependencies | ||
| if TYPE_CHECKING: | ||
| _NDArray = np.ndarray[Any, np.dtype[np.generic]] | ||
| _NumPyArrayGeneric = np.ndarray[Any, np.dtype[np.generic]] |
Contributor
Author
There was a problem hiding this comment.
I could actually import cv2.typing here so that the types don't fall out of sync. But the alias would still be necessary to avoid circular dependencies.
VadimLevin
approved these changes
Jul 12, 2023
Merged
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue in #23838 that re-introduced #23780 for
NumPyArrayGeneric,NumPyArrayFloat32,NumPyArrayFloat64and all their aliases/subtypes/unions. As well as supporting generic static hints in python 3.8.Read #23927 (comment) for the full explanation.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.