fix: recursively re-export nested submodules in typing stubs#23956
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Jul 11, 2023
Merged
Conversation
Contributor
Author
|
@Avasam what do you think regarding this change? |
Contributor
Contributor
|
I'm not sure that I got what this is about. |
Contributor
Author
Basically this is required to indicate that classes or functions are accessible without extra module imports. e.g. without this patch mypy will complain regarding the following usage import cv2
cv2.gapi.core.cpu.kernelsthat is completely legal in terms of cv2 package |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the same issue as #23809 , but also handles nested modules case
e.g. adds the following section to
cv2/gapi/__init__.pyi:Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.