Fixed possible out-of-bound access in circles drawing#23931
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Jul 21, 2023
Merged
Fixed possible out-of-bound access in circles drawing#23931asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
vrabaud
reviewed
Jul 5, 2023
| } | ||
|
|
||
| if( (unsigned)y12 < (unsigned)size.height ) | ||
| if( y12 >= 0 && y12 < size.height ) |
Contributor
There was a problem hiding this comment.
Though standard C++ promotion happens, y12 and size.height have different types so the compiler might complain. Casting to (int64_t) will it should be fine with our CI.
Contributor
Author
There was a problem hiding this comment.
it compares "int64_t < int" Both has sign and the comparison is always possible. I do not see any issues with the existing solution.
Contributor
|
LGTM |
21b1293 to
6a7ac8d
Compare
6a7ac8d to
52d9685
Compare
Contributor
Author
|
@vrabaud @opencv-alalek friendly reminder. |
Contributor
|
👍 |
vrabaud
approved these changes
Jul 20, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.