use CPACK_PACKAGE_VERSION instead of OPENCV_VCSVERSION for CPACK_PACKAGE_FILE_NAME#23918
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Jul 4, 2023
Merged
Conversation
…AGE_FILE_NAME so that OPENCV_CUSTOM_PACKAGE_INFO actually has full effect
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... so that OPENCV_CUSTOM_PACKAGE_INFO actually has full effect.
At the moment packages are generated (via cpack) with an invalid (by debian-standards) name. The version section of the name should at least start with the number and follow the pattern major:minor.patch-arch. at the moment the version string is set to the git-hash (which generates an invalid filename).
anyway, the real problem is that i can't even be fixed by using
OPENCV_CUSTOM_PACKAGE_INFObecauseVCS_VERSIONis used directly instead of assigning it to theCPACK_PACKAGE_VERSIONand using that.This pull request makes it possible to generate packages with debian conform names.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.