Skip to content

use CPACK_PACKAGE_VERSION instead of OPENCV_VCSVERSION for CPACK_PACKAGE_FILE_NAME#23918

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
kallaballa:custom_package_name
Jul 4, 2023
Merged

use CPACK_PACKAGE_VERSION instead of OPENCV_VCSVERSION for CPACK_PACKAGE_FILE_NAME#23918
asmorkalov merged 1 commit intoopencv:4.xfrom
kallaballa:custom_package_name

Conversation

@kallaballa
Copy link
Copy Markdown
Contributor

... so that OPENCV_CUSTOM_PACKAGE_INFO actually has full effect.

At the moment packages are generated (via cpack) with an invalid (by debian-standards) name. The version section of the name should at least start with the number and follow the pattern major:minor.patch-arch. at the moment the version string is set to the git-hash (which generates an invalid filename).
anyway, the real problem is that i can't even be fixed by using OPENCV_CUSTOM_PACKAGE_INFO because VCS_VERSION is used directly instead of assigning it to the CPACK_PACKAGE_VERSION and using that.
This pull request makes it possible to generate packages with debian conform names.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

…AGE_FILE_NAME so that OPENCV_CUSTOM_PACKAGE_INFO actually has full effect
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov self-assigned this Jul 4, 2023
@asmorkalov asmorkalov merged commit 356e5d3 into opencv:4.x Jul 4, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants