Merged
Conversation
bce37aa to
a2448a8
Compare
a2448a8 to
0f68e98
Compare
0f68e98 to
1d9c0d3
Compare
asmorkalov
reviewed
Jul 3, 2023
|
|
||
| static | ||
| // static | ||
| std::string icvExtractPattern(const std::string& filename, unsigned *offset) |
Contributor
There was a problem hiding this comment.
unsigned *offset -> unsigned& offset.
Contributor
There was a problem hiding this comment.
I propose to rename the function to extractFileNamePattern to follow common naming (not old C API).
Contributor
Author
There was a problem hiding this comment.
I tried to make as little modification in the source code as possible to simplify merge with #23815 . Maybe it would be better to postpone refactoring? I had some ideas, like multiple pattern support (e.g. frame_%d_%d.png), which would require to rework this function even more.
This was referenced Jul 27, 2023
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
icvExtractPatternfor testing purposesRelated: single image reading support - #23815 and #23808