Skip to content

Add pthread.h Inclusion if HAVE_PTHREADS_PF is defined#23855

Merged
asmorkalov merged 1 commit intoopencv:3.4from
thekpaul:3.4_patched
Jun 23, 2023
Merged

Add pthread.h Inclusion if HAVE_PTHREADS_PF is defined#23855
asmorkalov merged 1 commit intoopencv:3.4from
thekpaul:3.4_patched

Conversation

@thekpaul
Copy link
Copy Markdown
Contributor

@thekpaul thekpaul commented Jun 23, 2023 •
edited
Loading

Single-case tested with success on Windows 11 with MinGW-w64 Standalone GCC v13.1.0 while building OpenCV 4.7.0
Brought from #23849

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@thekpaul
Add pthread.h Inclusion if HAVE_PTHREADS_PF is defined
3b264d5 
Single-case tested with success on Windows 11 with MinGW-w64 Standalone GCC v13.1.0 while building OpenCV 4.7.0
@asmorkalov asmorkalov requested a review from opencv-alalek June 23, 2023 09:05
@asmorkalov asmorkalov added this to the 3.4.20 milestone Jun 23, 2023
opencv-alalek
opencv-alalek approved these changes Jun 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you!

@opencv-alalek opencv-alalek linked an issue Jun 23, 2023 that may be closed by this pull request
MinGW-w64 Standalone Environment Error: 'pthread_self' was not declared in this scope #23849
Closed
4 tasks
@asmorkalov asmorkalov merged commit d4f81c6 into opencv:3.4 Jun 23, 2023
@asmorkalov asmorkalov mentioned this pull request Jun 23, 2023
Merged
@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek approved these changes

Assignees

@opencv-alalek opencv-alalek

Labels

category: build/install

Projects

None yet

Milestone

3.4.20

Development

Successfully merging this pull request may close these issues.

MinGW-w64 Standalone Environment Error: 'pthread_self' was not declared in this scope

3 participants

@thekpaul @opencv-alalek @asmorkalov