Skip to content

Fix objectdetect module compilation without dnn#23818

Closed
TolyaTalamanov wants to merge 1 commit intoopencv:4.xfrom
TolyaTalamanov:at/fix-objectdect-compilation-without-dnn
Closed

Fix objectdetect module compilation without dnn#23818
TolyaTalamanov wants to merge 1 commit intoopencv:4.xfrom
TolyaTalamanov:at/fix-objectdect-compilation-without-dnn

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented Jun 16, 2023

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@TolyaTalamanov TolyaTalamanov requested a review from mshabunin June 16, 2023 10:18
@TolyaTalamanov TolyaTalamanov added this to the 4.8.0 milestone Jun 16, 2023
@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Jun 16, 2023

@mshabunin @asmorkalov Could you have a look, please?
Looks like signatures don't match:
https://github.com/opencv/opencv/blob/4.x/modules/objdetect/src/barcode_decoder/common/super_scale.hpp#L27
https://github.com/opencv/opencv/blob/4.x/modules/objdetect/src/barcode_decoder/common/super_scale.hpp#L54

Usage: https://github.com/opencv/opencv/blob/4.x/modules/objdetect/src/barcode.cpp#L184

@asmorkalov asmorkalov mentioned this pull request Jun 16, 2023
Merged
6 tasks
@mshabunin
Copy link
Copy Markdown
Contributor

mshabunin commented Jun 16, 2023

@TolyaTalamanov , thank you for finding the issue! My bad, I didn't make a final check.
I think the PR proposed by @asmorkalov would be better choice because it makes the code more errorproof.

@mshabunin mshabunin closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin Awaiting requested review from mshabunin

Assignees

No one assigned

Labels

category: objdetect

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@TolyaTalamanov @mshabunin