Skip to content

Barcode js bindings#23797

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/barcode_js_bindings
Jun 15, 2023
Merged

Barcode js bindings#23797
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/barcode_js_bindings

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Jun 14, 2023 •
edited
Loading

Merge after #23666
No JS test for now as model files are required
Also hacked std::string as JS generator omits namespaces by some reason

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.8.0 milestone Jun 14, 2023
@asmorkalov asmorkalov requested a review from mshabunin June 14, 2023 13:56
@asmorkalov asmorkalov force-pushed the as/barcode_js_bindings branch 2 times, most recently from c04b714 to 00377e5 Compare June 15, 2023 06:57
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Jun 15, 2023

@mshabunin I rebased the PR on top of current 4.x and fixed build issue found by BuildBot. Could you take a look again?

@opencv-alalek
Copy link
Copy Markdown
Contributor

opencv-alalek commented Jun 15, 2023

No JS test for now as model files are required

Model is optional in barcode. See: https://github.com/opencv/opencv/blob/4.x/modules/objdetect/perf/perf_barcode.cpp

@asmorkalov asmorkalov force-pushed the as/barcode_js_bindings branch from 00377e5 to 187a48a Compare June 15, 2023 10:39
mshabunin
mshabunin reviewed Jun 15, 2023
View reviewed changes
@asmorkalov asmorkalov force-pushed the as/barcode_js_bindings branch from 187a48a to 538b13a Compare June 15, 2023 12:02
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Jun 15, 2023

@opencv-alalek @mshabunin I added test and it passed on BuildBot.

@asmorkalov asmorkalov merged commit 0d7c039 into opencv:4.x Jun 15, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin mshabunin approved these changes

Assignees

@mshabunin mshabunin

Labels

category: javascript (js)

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asmorkalov @opencv-alalek @mshabunin