Skip to content

remove unsupported unsupported unicode “”#23783

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
zihaomu:remove_unsupported_character
Jun 12, 2023
Merged

remove unsupported unsupported unicode “”#23783
asmorkalov merged 1 commit intoopencv:4.xfrom
zihaomu:remove_unsupported_character

Conversation

@zihaomu
Copy link
Copy Markdown
Member

@zihaomu zihaomu commented Jun 11, 2023

MSVS compiler always gives a warning of “”. The “” should only be used in Chinese. So, I think we should replace them with "".

warning C4819

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@opencv-alalek opencv-alalek added this to the 4.8.0 milestone Jun 11, 2023
@asmorkalov asmorkalov merged commit e9c18c7 into opencv:4.x Jun 12, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants