Skip to content

JS bingings fix after Aruco-based QR code detector integration#23769

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/qrcode_js_fix
Jun 13, 2023
Merged

JS bingings fix after Aruco-based QR code detector integration#23769
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/qrcode_js_fix

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Jun 9, 2023

Address: regression #23737

  • Add new base class for QRCodeDetector to JS white-list
  • Resolve inheritance relations when all classes are parsed.
  • Add branch to handle std::vector<std::string> in method parameters.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
build_image:Docs=docs-js:18.04
build_image:Custom=javascript
buildworker:Custom=linux-1,linux-4,linux-f1

@asmorkalov
Copy link
Copy Markdown
Contributor Author

@opencv-alalek Could you take a look on the patch? CI tests for JS are green now.

Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@opencv-alalek opencv-alalek linked an issue Jun 13, 2023 that may be closed by this pull request
@asmorkalov asmorkalov merged commit 134d0b7 into opencv:4.x Jun 13, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

opencv.js: QR code test failure

2 participants