Skip to content

imgproc/cvtColor: fixed invalid read in BGR2HLS#23750

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
mshabunin:fix-bgr2hls-access
Jun 6, 2023
Merged

imgproc/cvtColor: fixed invalid read in BGR2HLS#23750
asmorkalov merged 1 commit intoopencv:4.xfrom
mshabunin:fix-bgr2hls-access

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin commented Jun 5, 2023

related PR #22520

  • mhls3 is read outside of array interTmpM (3 elements), it is not used anywhere
  • replacing max_nlanes with vlanes for array size is still in question, I think it should be OK It was not OK 😃

@mshabunin mshabunin force-pushed the fix-bgr2hls-access branch from 00f97ba to adab462 Compare June 5, 2023 20:26
@opencv-alalek opencv-alalek added this to the 4.8.0 milestone Jun 5, 2023
@asmorkalov asmorkalov requested a review from opencv-alalek June 6, 2023 06:48
@mshabunin mshabunin marked this pull request as ready for review June 6, 2023 07:56
@asmorkalov asmorkalov removed the request for review from opencv-alalek June 6, 2023 08:30
@asmorkalov
Copy link
Copy Markdown
Contributor

The issue existed before #22520, but was less obvious.

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov self-assigned this Jun 6, 2023
@asmorkalov asmorkalov merged commit b9ce87e into opencv:4.x Jun 6, 2023
@mshabunin mshabunin deleted the fix-bgr2hls-access branch July 10, 2023 08:13
@asmorkalov asmorkalov mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants