Skip to content

fixing typo in stitching parameter names#23740

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
kai-waang:4.x
Jun 9, 2023
Merged

fixing typo in stitching parameter names#23740
asmorkalov merged 1 commit intoopencv:4.xfrom
kai-waang:4.x

Conversation

@kai-waang
Copy link
Copy Markdown
Contributor

Fixing a typo in file modules/stitching/include/opencv2/stitching/detail/motion_estimators.hpp and motion_estimators.cpp, since the correct plural of "path" is "paths", not "pathes".

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.8.0 milestone Jun 5, 2023
@asmorkalov asmorkalov changed the title fixing typo fixing typo in stitching patarmeter names Jun 5, 2023
@asmorkalov asmorkalov changed the title fixing typo in stitching patarmeter names fixing typo in stitching parameter names Jun 5, 2023
@asmorkalov asmorkalov self-requested a review June 9, 2023 09:04
@asmorkalov asmorkalov self-assigned this Jun 9, 2023
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch breaks parameters naming in Python bindings. The issue is discussed on OpenCV core team meeting and it's decided to merge it.

@asmorkalov asmorkalov merged commit 0c8e6e0 into opencv:4.x Jun 9, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants