Fixed FPS computation on some videos for FFmpeg backend#23669
Closed
asmorkalov wants to merge 1 commit intoopencv:4.xfrom
Closed
Fixed FPS computation on some videos for FFmpeg backend#23669asmorkalov wants to merge 1 commit intoopencv:4.xfrom
asmorkalov wants to merge 1 commit intoopencv:4.xfrom
Conversation
| { | ||
| #if 0 && LIBAVFORMAT_BUILD >= CALC_FFMPEG_VERSION(55, 1, 100) && LIBAVFORMAT_VERSION_MICRO >= 100 | ||
| #if LIBAVFORMAT_BUILD >= CALC_FFMPEG_VERSION(55, 1, 100) && LIBAVFORMAT_VERSION_MICRO >= 100 | ||
| double fps = r2d(av_guess_frame_rate(ic, ic->streams[video_stream], NULL)); |
Contributor
There was a problem hiding this comment.
LIBAVFORMAT_VERSION_MICRO >= 100
It is for FFmpeg only. What is about libav?
May be reimplement that function here?
https://github.com/FFmpeg/FFmpeg/blame/n3.4.1/libavformat/utils.c#L4936
It makes sense to target this patch for 3.4 branch too - there is libav on Linux builder.
Contributor
Author
There was a problem hiding this comment.
av_guess_frame_rate does not exist in libav. I tried libav repo master and several release tags.
6 tasks
Contributor
Author
|
The same patch will be promoted from 3.4. Closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address ##21006
Introduced in #7213. Most probably a typo.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.