Skip to content

WIP: [G-API] IE Backend: Update the condition for applying the resize preprocessing#23668

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
TolyaTalamanov:at/fix-resize-applying-logic-ie-backend
Jun 1, 2023
Merged

WIP: [G-API] IE Backend: Update the condition for applying the resize preprocessing#23668
asmorkalov merged 1 commit intoopencv:4.xfrom
TolyaTalamanov:at/fix-resize-applying-logic-ie-backend

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented May 24, 2023

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@TolyaTalamanov TolyaTalamanov added this to the 4.8.0 milestone May 24, 2023
@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented May 24, 2023

@dmatveev Could you have a look, please?

@asmorkalov asmorkalov requested a review from dmatveev May 24, 2023 13:51
dmatveev
dmatveev approved these changes May 31, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this break any of our existing OMZ demos?
Also, do you see IE tests running in GH Actions (I've never checked)

@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Jun 1, 2023

@asmorkalov this one can be merged I believe

@dmatveev dmatveev changed the title [G-API] IE Backend: Update the condition for applying the resize preprocessing WIP: [G-API] IE Backend: Update the condition for applying the resize preprocessing Jun 1, 2023
@dmatveev dmatveev marked this pull request as draft June 1, 2023 10:54
@asmorkalov asmorkalov marked this pull request as ready for review June 1, 2023 10:54
@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Jun 1, 2023

Moved to draft per discussion with @TolyaTalamanov

@asmorkalov asmorkalov merged commit 2104d61 into opencv:4.x Jun 1, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@TolyaTalamanov @dmatveev @asmorkalov