Skip to content

Fix Objective-C generator handling of base class names#23598

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
komakai:fix-objc-gen-baseclass
May 10, 2023
Merged

Fix Objective-C generator handling of base class names#23598
asmorkalov merged 1 commit intoopencv:4.xfrom
komakai:fix-objc-gen-baseclass

Conversation

@komakai
Copy link
Copy Markdown
Contributor

@komakai komakai commented May 10, 2023

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch

Fixes issue blocking #23264

I think at some point I was trying to solve an issue with conflicting class names by appending the module name to the class name. This resulted in problems where the class with the conflicting name was later used as a base class.
Whatever the original problem - I have confirmed that this change has no impact on the current Objective-C wrappers for modules in both opencv and opencv_contrib

@asmorkalov
Copy link
Copy Markdown
Contributor

Tested in joined PR: #23599

@asmorkalov asmorkalov self-assigned this May 10, 2023
@asmorkalov asmorkalov merged commit 8baabdf into opencv:4.x May 10, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants