Skip to content

Add int64, uint64, bool, uint data type.#23591

Closed
zihaomu wants to merge 2 commits intoopencv:4.xfrom
zihaomu:add_new_data_type
Closed

Add int64, uint64, bool, uint data type.#23591
zihaomu wants to merge 2 commits intoopencv:4.xfrom
zihaomu:add_new_data_type

Conversation

@zihaomu
Copy link
Copy Markdown
Member

@zihaomu zihaomu commented May 9, 2023 •
edited
Loading

Since we only have three bits for the data type, this PR wants to expand the number of bits of the data type to 4 bits.

At present, there are many aspects of this PR that have not been considered. Any suggestions are welcome.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@zihaomu zihaomu added category: core feature pr: needs test New functionality requires minimal tests set labels May 9, 2023
zihaomu
zihaomu commented May 9, 2023
View reviewed changes
modules/core/include/opencv2/core/hal/interface.h Outdated
#define CV_16F 7
#define CV_64S 8
#define CV_64U 9
#define CV_BOOL 10
Copy link
Copy Markdown
Member Author

@zihaomu zihaomu May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CV_BOOL conflicts with the CV_BOOL of modules/gapi/include/opencv2/gapi/gcommon.hpp

Copy link
Copy Markdown
Member Author

@zihaomu zihaomu May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temporary solution: CV_BOOL -> CV_1BOOL.

@zihaomu zihaomu marked this pull request as draft May 9, 2023 08:29
@zihaomu zihaomu requested a review from vpisarev May 9, 2023 08:58
@opencv-alalek
Copy link
Copy Markdown
Contributor

opencv-alalek commented May 9, 2023

related discussions #12584

@opencv-alalek opencv-alalek added this to the 5.0 milestone May 9, 2023
@vpisarev vpisarev changed the base branch from 4.x to 5.x June 19, 2023 14:06
@vpisarev vpisarev changed the base branch from 5.x to 4.x June 19, 2023 14:06
@vpisarev
Copy link
Copy Markdown
Contributor

vpisarev commented Jun 19, 2023

Dear @zihaomu, thank you for PR, this is really useful! Let me close this PR and create a new one with 5.x target.

@vpisarev vpisarev closed this Jun 19, 2023
@vpisarev vpisarev mentioned this pull request Jun 24, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpisarev vpisarev Awaiting requested review from vpisarev

Assignees

No one assigned

Labels

category: core feature pr: needs test New functionality requires minimal tests set RFC

Projects

None yet

Milestone

5.0-alpha

Development

Successfully merging this pull request may close these issues.

3 participants

@zihaomu @opencv-alalek @vpisarev