Fix aruco module CORNER_REFINE_CONTOUR parameter gets skipped#23495
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Apr 20, 2023
smeng9:4.x
Merged
Fix aruco module CORNER_REFINE_CONTOUR parameter gets skipped#23495asmorkalov merged 1 commit intoopencv:4.xfrom smeng9:4.x
asmorkalov merged 1 commit intoopencv:4.xfrom
smeng9:4.x
Conversation
Contributor
|
@smeng9 Thanks a lot for the issue debugging and contribution! Could you add small test for the issue or tune some existing? |
Contributor
|
The fix works. |
AleksandrPanov
approved these changes
Apr 20, 2023
Contributor
AleksandrPanov
left a comment
There was a problem hiding this comment.
I checked the PR, the fix works. It is difficult to add a good test, I suggest to merge it.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
Hi @AleksandrPanov the aruco module is using the wrong variable to check whether it should perform corner refinement.
The previous buggy version of code since opencv 4.7 is using the candidates supplied in the function argument from user instead of the candidates returned from
_identifyCandidates.Our current workaround is always to run the detectMarkers twice, so the second time will use the ids returned from the first run, however that workaround is not optimal and greatly hurt the performance.
Could you please take a look and get this merged? Thanks!
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.