Skip to content

[G-API] Handle meta from multiple inputs in IE backend#23477

Merged
asmorkalov merged 3 commits intoopencv:4.xfrom
TolyaTalamanov:at/handle-multimeta-giebackend
Apr 12, 2023
Merged

[G-API] Handle meta from multiple inputs in IE backend#23477
asmorkalov merged 3 commits intoopencv:4.xfrom
TolyaTalamanov:at/handle-multimeta-giebackend

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented Apr 10, 2023 •
edited
Loading

Overview

Since IE backend implements "streaming" run(IInput&, IOutput&)method it must take care of propagating meta from inputs.

The handling implemented the same way as for the default GIslandModel::run: https://github.com/opencv/opencv/blob/4.x/modules/gapi/src/compiler/gislandmodel.cpp#L436-L440
Since post is done in PostOutputs / PostOutputsList callback functions, meta collected and moved to IECallContext.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from dmatveev April 10, 2023 10:02
@asmorkalov asmorkalov added category: t-api cv::UMat related issues feature labels Apr 10, 2023
@TolyaTalamanov TolyaTalamanov added category: g-api / gapi and removed category: t-api cv::UMat related issues labels Apr 10, 2023
@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Apr 10, 2023

@dmatveev Could you have a look, please?

dmatveev
dmatveev approved these changes Apr 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Apr 11, 2023

@asmorkalov Can it be merged?

@asmorkalov asmorkalov added this to the 4.8.0 milestone Apr 12, 2023
@asmorkalov asmorkalov merged commit 1af084c into opencv:4.x Apr 12, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi feature

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@TolyaTalamanov @dmatveev @asmorkalov