Use NV12 instead of YUY2 for OBS Virtual Camera.#23469
Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom Apr 10, 2023
Merged
Use NV12 instead of YUY2 for OBS Virtual Camera.#23469opencv-pushbot merged 1 commit intoopencv:4.xfrom
opencv-pushbot merged 1 commit intoopencv:4.xfrom
Conversation
5c0def0 to
d30830d
Compare
opencv-alalek
approved these changes
Apr 10, 2023
Contributor
opencv-alalek
left a comment
There was a problem hiding this comment.
LGTM 👍
- Validated with OBS
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #23460. Since OBS uses NV12 internally, it's better to capture in NV12 to avoid unnecessary conversions on the OBS side. This also removes the YUY2 implementation changes in #23460 that were specific to the OBS Virtual Camera.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request