Skip to content

Switch rows and cols in call to Mat.zeros#23449

Merged
asmorkalov merged 1 commit intoopencv:3.4from
Zwyx:fix-mat-zeros-rows-cols
Apr 4, 2023
Merged

Switch rows and cols in call to Mat.zeros#23449
asmorkalov merged 1 commit intoopencv:3.4from
Zwyx:fix-mat-zeros-rows-cols

Conversation

@Zwyx
Copy link
Copy Markdown
Contributor

@Zwyx Zwyx commented Apr 2, 2023

In a JS example, arguments rows and cols in a call to Mat.zeros were switched. The correct order is rows then cols:
https://docs.opencv.org/4.x/d3/d63/classcv_1_1Mat.html#a56daa006391a670e9cb0cd08e3168c99

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov self-requested a review April 4, 2023 08:06
@asmorkalov asmorkalov self-assigned this Apr 4, 2023
@asmorkalov asmorkalov added this to the 4.8.0 milestone Apr 4, 2023
@asmorkalov asmorkalov merged commit bac7180 into opencv:3.4 Apr 4, 2023
@asmorkalov asmorkalov mentioned this pull request Apr 20, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants