Skip to content

Fix error of POSE_PAIRS in pose estimation doc#23380

Merged
asmorkalov merged 1 commit intoopencv:3.4from
zero-nnkn:pose_doc
Mar 21, 2023
Merged

Fix error of POSE_PAIRS in pose estimation doc#23380
asmorkalov merged 1 commit intoopencv:3.4from
zero-nnkn:pose_doc

Conversation

@zero-nnkn
Copy link
Copy Markdown
Contributor

@zero-nnkn zero-nnkn commented Mar 20, 2023

doc/js_tutorials/js_assets/js_pose_estimation.html

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Mar 21, 2023

Thanks a lot for the patch! The fix looks correct according to this instruction: https://cmu-perceptual-computing-lab.github.io/openpose/web/html/doc/md_doc_02_output.html#pose-output-format-body_25.

@asmorkalov asmorkalov added the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label Mar 21, 2023
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Mar 21, 2023

The same issue exists in branch 3.4 too. Could you rebase the branch to 3.4 and retarget the patch to 3.4. OpenCV team will promote the fix to all active branches during regular 3.4->4.x merge.

@asmorkalov asmorkalov changed the base branch from 4.x to 3.4 March 21, 2023 11:38
@asmorkalov asmorkalov added bug and removed pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch labels Mar 21, 2023
@asmorkalov asmorkalov self-requested a review March 21, 2023 11:38
@asmorkalov asmorkalov self-assigned this Mar 21, 2023
@asmorkalov asmorkalov merged commit 0d2f21b into opencv:3.4 Mar 21, 2023
@asmorkalov asmorkalov added this to the 3.4.20 milestone Mar 21, 2023
@zero-nnkn
Copy link
Copy Markdown
Contributor Author

zero-nnkn commented Mar 21, 2023

Thank you for finishing it.

@asmorkalov asmorkalov mentioned this pull request Apr 20, 2023
Merged
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

bug category: javascript (js)

Projects

None yet

Milestone

3.4.20

Development

Successfully merging this pull request may close these issues.

2 participants

@zero-nnkn @asmorkalov