Skip to content

cmake: fix V4L config verification conflict with OBSENSOR#23375

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
mshabunin:fix-v4l-verify
Apr 18, 2023
Merged

cmake: fix V4L config verification conflict with OBSENSOR#23375
asmorkalov merged 1 commit intoopencv:4.xfrom
mshabunin:fix-v4l-verify

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin commented Mar 19, 2023

resolves #23083

When building with WITH_V4L=OFF and WITH_OBSENSOR=ON config verification fails due to variable HAVE_CAMV4L being set by OBSENSOR and used for verification by V4L.

@asmorkalov
Copy link
Copy Markdown
Contributor

@mshabunin Is the PR ready for review?

@asmorkalov asmorkalov marked this pull request as ready for review April 14, 2023 09:00
@mshabunin
Copy link
Copy Markdown
Contributor Author

I haven't check it myself, but it should be fine.

@zihaomu
Copy link
Copy Markdown
Member

zihaomu commented Apr 17, 2023

Hi @mshabunin, I will test it on my site.

Copy link
Copy Markdown
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test with Orbbec camera, it works well.
Orbbec camera: Femto
Test platform: ARM, ubuntu 20.04.
Compiler config:

-D WITH_V4L=OFF \
-D WITH_OBSENSOR=ON \

@asmorkalov asmorkalov merged commit b68aa12 into opencv:4.x Apr 18, 2023
@mshabunin mshabunin deleted the fix-v4l-verify branch April 18, 2023 11:44
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verifying the config fails if option is disabled but prerequisites exist, that seems flawed?

3 participants