DNN Test ONNX: Fix the logic of the test case#23343
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Mar 13, 2023
Merged
Conversation
asmorkalov
reviewed
Mar 13, 2023
Comment on lines
-1067
to
-1070
| if (global_deny_list.find(name) != global_deny_list.end()) | ||
| { | ||
| applyTestTag(CV_TEST_TAG_DNN_SKIP_OPENCV_BACKEND, CV_TEST_TAG_DNN_SKIP_ONNX_CONFORMANCE); | ||
| } |
Contributor
There was a problem hiding this comment.
There is no dedicated skip list for OpenCV backend after the patch. I propose to add it and let it be empty for now.
Member
Author
There was a problem hiding this comment.
Hi @asmorkalov thanks for the code reviewing. To my knowledge, the cpu_deny_list is made for OpenCV backend. I'm not sure about it.
b306392 to
ee3740a
Compare
asmorkalov
approved these changes
Mar 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
global_deny_listout ofifcondition.global_deny_listwas set to that can be parsed correctly, but cannot run on any backend.It should have nothing to do with
backend.For example: some bad case in the
global_deny_listbut not in thevulkan_deny_list, the Vulkan CI will fail with these cases.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.