Skip to content

core(simd): 64-bit integer EQ/NE without misused 64F guard#23307

Merged
asmorkalov merged 1 commit intoopencv:3.4from
alalek:simd_comparison_fix_misused_64f_guard
Mar 24, 2023
Merged

core(simd): 64-bit integer EQ/NE without misused 64F guard#23307
asmorkalov merged 1 commit intoopencv:3.4from
alalek:simd_comparison_fix_misused_64f_guard

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Feb 27, 2023 •
edited
Loading

relates #7175
relates #15738

discussion #23098 (comment)

OpenCV SIMD backends:

  • SSE*
  • AVX2
  • AVX512
  • NEON ARMv7 (validated through qemu-arm -cpu cortex-a15)
  • NEON ARMv8 / AARCH64
  • RVV: 1 2
  • JS/WASM SIMD (buggy implementation through f64 - doesn't work properly with NaN - also no JS tests here)
  • VSX (no CI, but CV_SIMD128_64F=1)
  • MSA (no CI, but CV_SIMD128_64F=1)
  • LASX (no CI, but CV_SIMD128_64F=1)
Xforce_builders=Custom
Xbuild_image:Custom=riscv-gcc
Xbuild_image:Custom=riscv-gcc-rvv
Xbuild_image:Custom=riscv-clang
Xbuild_image:Custom=riscv-clang-rvv
Xbuild_image:Custom=riscv-clang-rvv-128

test_modules:Custom=core,imgproc,dnn
buildworker:Custom=linux-4
test_timeout:Custom=600
build_contrib:Custom=OFF

@asmorkalov asmorkalov requested a review from vpisarev March 24, 2023 08:32
@asmorkalov asmorkalov merged commit 36a03db into opencv:3.4 Mar 24, 2023
@asmorkalov asmorkalov mentioned this pull request Apr 20, 2023
Merged
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpisarev vpisarev vpisarev approved these changes

Assignees

@vpisarev vpisarev

Labels

bug category: core feature optimization RFC

Projects

None yet

Milestone

3.4.20

Development

Successfully merging this pull request may close these issues.

3 participants

@alalek @vpisarev @asmorkalov