dnn(tflite): add 3rdparty flatbuffers with pre-generated schema#23274
Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom Feb 21, 2023
Merged
dnn(tflite): add 3rdparty flatbuffers with pre-generated schema#23274opencv-pushbot merged 1 commit intoopencv:4.xfrom
opencv-pushbot merged 1 commit intoopencv:4.xfrom
Conversation
Member
|
BTW, is there limitation why OpenCV does not support submodules instead? |
Member
Author
|
We don't use submodules in the main OpenCV repositories. |
dkurt
reviewed
Feb 20, 2023
modules/dnn/CMakeLists.txt
Outdated
| endif() | ||
|
|
||
| if(HAVE_FLATBUFFERS) | ||
| ocv_option(OPENCV_TEST_DNN_TFLITE "Build test with TFLite" (TARGET ocv.3rdparty.flatbuffers)) |
Member
Author
There was a problem hiding this comment.
Thanks! Updated handing of this option in tests. It should be more clear now (flatbuffers -> tflite)
mshabunin
approved these changes
Feb 20, 2023
Contributor
mshabunin
left a comment
There was a problem hiding this comment.
Overall looks good to me.
| set(flatbuffers_VERSION "23.1.21") | ||
| ocv_install_3rdparty_licenses(flatbuffers "${OpenCV_SOURCE_DIR}/3rdparty/flatbuffers/LICENSE.txt") | ||
| ocv_add_external_target(flatbuffers "${OpenCV_SOURCE_DIR}/3rdparty/flatbuffers/include" "" "HAVE_FLATBUFFERS=1") | ||
| set(CUSTOM_STATUS_flatbuffers " Flatbuffers:" "builtin/3rdparty (${flatbuffers_VERSION})") |
Contributor
There was a problem hiding this comment.
Why not like other libraries?
Suggested change
| set(CUSTOM_STATUS_flatbuffers " Flatbuffers:" "builtin/3rdparty (${flatbuffers_VERSION})") | |
| set(CUSTOM_STATUS_flatbuffers " Flatbuffers:" "build (${flatbuffers_VERSION})") |
Or will we change others to the new style eventually (e.g. protobuf)?
Member
Author
There was a problem hiding this comment.
flatbuffers is integrated as headers only (there is no compilation of the library). IMHO, build may confuse here.
dkurt
approved these changes
Feb 21, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates #23161
https://github.com/google/flatbuffers/releases/tag/v23.1.21 (Apache 2.0)
TODO: