Aruco/Charuco test case fixes for floating point for loops#23271
Merged
asmorkalov merged 2 commits intoopencv:4.xfrom Mar 30, 2023
Merged
Aruco/Charuco test case fixes for floating point for loops#23271asmorkalov merged 2 commits intoopencv:4.xfrom
asmorkalov merged 2 commits intoopencv:4.xfrom
Conversation
6 tasks
9037782 to
66afede
Compare
66afede to
c643af0
Compare
AleksandrPanov
approved these changes
Mar 29, 2023
Contributor
AleksandrPanov
left a comment
There was a problem hiding this comment.
I support "for loop fixes", this makes the tests more understandable.
Also, I removed the image size increase so as not to increase the time of the tests. We can use "distance" param to increase aruco markers.
In current tests, there are several pixels per module. This will help track regressions, but a small change in the parameters of the tests can lead to their fall.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aruco/Charuco test case
forloop fixes as discussed in #23153There are some test loops in the aruco/charuco module that do not work as intended due to floating point imprecision.
Pull Request Readiness Checklist
Patch to opencv_extra has the same branch name.