Skip to content

Fix rootsift#23204

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
whuaegeanse:fix-sift
Feb 1, 2023
Merged

Fix rootsift#23204
opencv-pushbot merged 1 commit intoopencv:3.4from
whuaegeanse:fix-sift

Conversation

@whuaegeanse
Copy link
Copy Markdown
Contributor

Fix rootsift

@whuaegeanse whuaegeanse changed the title Fix bug Fix rootsift Jan 31, 2023
@alalek
Copy link
Copy Markdown
Member

alalek commented Jan 31, 2023

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into 4.x regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: 4.x => 3.4 (use "Edit" button near PR title)
  • rebase your commits from 4.x onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/4.x
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@whuaegeanse whuaegeanse changed the base branch from 4.x to 3.4 February 1, 2023 02:56
@whuaegeanse whuaegeanse changed the base branch from 3.4 to 4.x February 1, 2023 03:35
@whuaegeanse whuaegeanse changed the base branch from 4.x to 3.4 February 1, 2023 04:05
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@opencv-pushbot opencv-pushbot merged commit cb2052d into opencv:3.4 Feb 1, 2023
@alalek alalek mentioned this pull request Feb 11, 2023
@whuaegeanse whuaegeanse deleted the fix-sift branch March 28, 2023 11:50
@asmorkalov asmorkalov mentioned this pull request Apr 20, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants