RISC-V RVV 0.7: v_add/v_sub saturation and avoiding 64-bit VLEN#23198
Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom Jan 31, 2023
Merged
RISC-V RVV 0.7: v_add/v_sub saturation and avoiding 64-bit VLEN#23198opencv-pushbot merged 1 commit intoopencv:4.xfrom
opencv-pushbot merged 1 commit intoopencv:4.xfrom
Conversation
alalek
approved these changes
Jan 31, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two fixes for RISC-V RVV 0.7 intrinsics:
Apparently 32- and 64-bit types differ from 8- and 16-bit, e.g. NEON intrinsics have same pattern (
vqadd- saturated,vadd- wraps on overflow):opencv/modules/core/include/opencv2/core/hal/intrin_neon.hpp
Lines 473 to 493 in ff8af10
v_check_intrinsics use 32-bit element size to avoid 64-bit operations which are not supported by HW