Fix encodeStructuredAppend() resulting in only one QR code problem, and false output data fix.#23168
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Jan 30, 2023
Conversation
Contributor
Author
|
@alalek @AleksandrPanov |
Contributor
Author
|
@AleksandrPanov It seems like our decoder doesn't support Structured Append mode yet, but i managed to validate the data using an online decoder and it works. Please let me know if i should add the data validation on the regression test and mark is as DISABLED. |
6 tasks
AleksandrPanov
approved these changes
Jan 24, 2023
Contributor
AleksandrPanov
left a comment
There was a problem hiding this comment.
@genciberisha, thank for your work, LGTM
You're right, OpenCV decoder cannot read QR codes with Structured Append mode (None of the QR codes from the sequence could be read with OpenCV).
asmorkalov
requested changes
Jan 25, 2023
Added regression parameterized test for Structure Append mode final_qr_code clear outside generateQR() method
790fafb to
743d4ec
Compare
asmorkalov
approved these changes
Jan 27, 2023
Contributor
Author
|
@alalek I believe there isn't anything left to do in this PR, if there is please let me know. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22205 and #23105
While splitting the data to multiple QR codes it constantly cleans the resulting vector(final_qr_codes).
The fix is to just clean the result vector after all work is done with it.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.