Stereo calibration perView pose output: port to 5.x#23150
Merged
asmorkalov merged 12 commits intoopencv:5.xfrom Feb 2, 2023
Merged
Stereo calibration perView pose output: port to 5.x#23150asmorkalov merged 12 commits intoopencv:5.xfrom
asmorkalov merged 12 commits intoopencv:5.xfrom
Conversation
asmorkalov
reviewed
Feb 1, 2023
| InputOutputArray cameraMatrix2, InputOutputArray distCoeffs2, | ||
| Size imageSize, InputOutputArray R, InputOutputArray T, OutputArray E, OutputArray F, | ||
| OutputArray perViewErrors, int flags = CALIB_FIX_INTRINSIC, | ||
| TermCriteria criteria = TermCriteria(TermCriteria::COUNT+TermCriteria::EPS, 30, 1e-6) ); |
Contributor
There was a problem hiding this comment.
Why TermCriteria limited to 30 iterations, but not 100 as in other overloads?
Contributor
Author
There was a problem hiding this comment.
No idea, that what was introduced in the original PR.
I've replaced 100 by 30 everywhere in stereoCalibrate, everything works fine. I propose to leave these 30 iterations since we reach the same level of quality with less iterations
asmorkalov
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.