Skip to content

perf: drop runtime time adjustment calibration#23148

Merged
asmorkalov merged 1 commit intoopencv:3.4from
alalek:perf_drop_calibration
Jan 20, 2023
Merged

perf: drop runtime time adjustment calibration#23148
asmorkalov merged 1 commit intoopencv:3.4from
alalek:perf_drop_calibration

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Jan 18, 2023

This may unexpectedly broke performance reports and provide wrong results due to measurement in runtime.

  • it measures a time between exiting of startTimer(), iter++ and calling of stopTimer(). Critical code path is minimized for this flow.
  • on properly configured system its value is almost zero: about 10-11 clock ticks (ns, on Linux x86). By comparing to 1'000'000 clock ticks of 1ms sample measurement - it is a nothing.
  • other values are not expected (and not observed during the 5+ years). Other values would just break the numbers in the performance report.
  • this value is already ignored (forced to 0) for PERF_STRATEGY_SIMPLE which is default since 2014.

Lets remove this unnecessary step of performance tests startup.

@asmorkalov asmorkalov self-requested a review January 20, 2023 08:28
@asmorkalov asmorkalov merged commit e200b88 into opencv:3.4 Jan 20, 2023
This was referenced Jan 21, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants