Fix Heap-buffer-overflow READ in opj_jp2_apply_pclr#23067
Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom Feb 5, 2023
Merged
Fix Heap-buffer-overflow READ in opj_jp2_apply_pclr#23067opencv-pushbot merged 1 commit intoopencv:4.xfrom
opencv-pushbot merged 1 commit intoopencv:4.xfrom
Conversation
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=47342 The read overflow triggered by reading `src[j]` in ```cpp for (j = 0; j < max; ++j) { dst[j] = src[j]; } ``` The max is calculated as `new_comps[pcol].w * new_comps[pcol].h`, however the `src = old_comps[cmp].data;` which may have different `w` and `h` dimensions.
Contributor
Author
|
Logs are not available so I cannot see why some checks have failed. But I doubt that it is related. |
Contributor
Author
|
Re-run triggered 15 hours ago. Some jobs succeeded. Some didn't even start, waiting for runner. Hanging? |
Contributor
Author
|
Is it good to be merged? |
alalek
approved these changes
Feb 5, 2023
Member
alalek
left a comment
There was a problem hiding this comment.
LGTM 👍
(patch in 3rdparty's upstream has been merged)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=47342
The read overflow triggered by reading
src[j]inThe max is calculated as
new_comps[pcol].w * new_comps[pcol].h, however thesrc = old_comps[cmp].data;which may have differentwandhdimensions.The patch was contributed to the third party library openjpeg uclouvain/openjpeg#1441
Normally I would suggest to update to openjpeg 2.5.1 when released, but there was no release in 4 months and from security point of view I suggest to make the hot fix for now and bump the version when available. The tracking issue was created - #23066
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.