Skip to content

CUDA: add Ada Lovelace and Hopper CC#23062

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
cudawarped:cuda_add_lovelace_hopper
Jan 9, 2023
Merged

CUDA: add Ada Lovelace and Hopper CC#23062
asmorkalov merged 1 commit intoopencv:4.xfrom
cudawarped:cuda_add_lovelace_hopper

Conversation

@cudawarped
Copy link
Copy Markdown
Contributor

@cudawarped cudawarped commented Dec 30, 2022 •
edited
Loading

Update automatic CC detection script with CC introduced in CUDA SDK 11.8

  • Ada Lovelace has CC 8.9
  • Hopper has CC 9.0

cc @tomoaki0705

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@tomoaki0705
Copy link
Copy Markdown
Contributor

tomoaki0705 commented Dec 30, 2022

Thank you for your contribution.

Does this PR goes to 4.x ?
Why not following the ordinary procedure ? (first to 3.4 branch and then propagate to master)

@cudawarped cudawarped force-pushed the cuda_add_lovelace_hopper branch from 5f155e5 to f0ddd5b Compare December 30, 2022 07:34
@cudawarped
Copy link
Copy Markdown
Contributor Author

cudawarped commented Dec 30, 2022

Does this PR goes to 4.x ?
Why not following the ordinary procedure ? (first to 3.4 branch and then propagate to master)

I have now pushed the changes from the 3.4 branch. The PR title still states opencv:4.x do I need to close this and open a new PR to the correct branch?

@tomoaki0705
Copy link
Copy Markdown
Contributor

tomoaki0705 commented Dec 30, 2022 •
edited
Loading

Please DON'T close the Pull Request but follow the correct procedure.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request

@cudawarped cudawarped changed the base branch from 4.x to 3.4 December 30, 2022 07:49
@asmorkalov asmorkalov self-requested a review January 9, 2023 11:35
@asmorkalov asmorkalov added category: build/install category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib labels Jan 9, 2023
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jan 9, 2023

Sorry for inconvenience, but the parch should go to 4.x. 3.4 still uses old texture API:

odules/cudev/include/opencv2/cudev/ptr2d/texture.hpp(61): error: texture is not a template

@cudawarped cudawarped changed the base branch from 3.4 to 4.x January 9, 2023 12:02
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jan 9, 2023

The branch is still based on 3.4. Please rebase it on top of 4.x.

@cudawarped cudawarped force-pushed the cuda_add_lovelace_hopper branch from f0ddd5b to 927aa1e Compare January 9, 2023 13:45
asmorkalov
asmorkalov approved these changes Jan 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 No chance to check with real GPU, but build is ok. Tested with Ubuntu 20.04 and CUDA 12.

@asmorkalov asmorkalov self-assigned this Jan 9, 2023
@asmorkalov asmorkalov merged commit b16a4ba into opencv:4.x Jan 9, 2023
@asmorkalov asmorkalov added this to the 4.8.0 milestone Jan 9, 2023
@alalek alalek mentioned this pull request Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: build/install category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cudawarped @tomoaki0705 @asmorkalov