Skip to content

Add missing ORB.setFastThreshold(int) method#23043

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
AlejandroSilvestri:patch-1
Dec 27, 2022
Merged

Add missing ORB.setFastThreshold(int) method#23043
opencv-pushbot merged 1 commit intoopencv:4.xfrom
AlejandroSilvestri:patch-1

Conversation

@AlejandroSilvestri
Copy link
Copy Markdown
Contributor

@AlejandroSilvestri AlejandroSilvestri commented Dec 27, 2022

ORB constructor is failing to set the very important protected parameter fastThreshold, so binding this method is necessary.
Related to #17395 (comment)

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
build_image:Custom=javascript
buildworker:Custom=linux-1

ORB constructor is failing to set the very important protected parameter fastThreshold,
so binding this method is necessary.
@opencv-pushbot opencv-pushbot merged commit 838c34e into opencv:4.x Dec 27, 2022
@AlejandroSilvestri AlejandroSilvestri deleted the patch-1 branch December 27, 2022 15:50
@alalek alalek mentioned this pull request Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants