Fix for using sampleIdx to limit training data#23019
Merged
asmorkalov merged 1 commit intoopencv:3.4from Mar 22, 2023
Merged
Conversation
vpisarev
approved these changes
Mar 18, 2023
Contributor
|
@tkram01 Friendly reminder. Please take a look on CI failures. |
Contributor
|
@tkram01 |
Contributor
|
Also the same issue exists in 3.4 branch too. Please rebase your branch on top of 3.4 and re-target the PR to 3.4 too. OpenCV team will propagate the fix to 4.x and other branches during regular merge procedure later. |
f922cca to
ea7efd5
Compare
Contributor
|
Rebased to 3.4 and fixed operations order. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a sampleIdx Mat to limit the training samples to train on the current code will fail with an assert since it is checking that the index is < the length of the samples to train on instead of the available samples.