Fix maxIter parameter in usac findEssentialMat #22967
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Dec 21, 2022
Merged
Conversation
Contributor
|
@stopmosk could you add simple test to prove the result. |
Contributor
|
@ivashmak Could you take a look? |
asmorkalov
reviewed
Dec 19, 2022
asmorkalov
approved these changes
Dec 20, 2022
Contributor
|
@alalek could we merge the patch? |
Contributor
Everything looks fine, but I would also suggest changing this line: |
b974834 to
3cfe737
Compare
Contributor
|
@ivashmak Thanks a lot for the review. I fixed your remark and squashed commits before merge. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a default parameter
maxIterstofindEssentialMatand replaced the hardcoded value of1000inransac_solvers.hpp. Fix for issue #22696Test to check:
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.