Skip to content

Fix missing FFmpeg include needed for av_get_pix_fmt_name#22958

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
asmorkalov:as/ffmpeg_missing_include
Dec 14, 2022
Merged

Fix missing FFmpeg include needed for av_get_pix_fmt_name#22958
opencv-pushbot merged 1 commit intoopencv:4.xfrom
asmorkalov:as/ffmpeg_missing_include

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Dec 14, 2022 •
edited by alalek
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
build_image:Custom=ubuntu:14.04

@asmorkalov asmorkalov requested a review from mshabunin December 14, 2022 10:19
@asmorkalov asmorkalov added this to the 4.7.0 milestone Dec 14, 2022
@alalek
Copy link
Copy Markdown
Member

alalek commented Dec 14, 2022

Which FFmpeg version requires this?

@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Dec 14, 2022

It's libav installed on Ubuntu 14.04. The symbol itself appeared in 2012.

@mshabunin
Copy link
Copy Markdown
Contributor

mshabunin commented Dec 14, 2022 •
edited
Loading

Oh, I've tried to test libav (https://github.com/mshabunin/videoio-ffmpeg-check/blob/c88bc86d23912f55c587433981f425fd7882eae5/download.sh#L31-L33), but decided that we won't support it anymore as this library seem to not be active.

@opencv-pushbot opencv-pushbot merged commit 04c3a53 into opencv:4.x Dec 14, 2022
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Dec 15, 2022

I use Jetson tk1 for ARM v7 testing. It freezes with Ubuntu 14.04 and I have to deal with minor build issues here and there.

@alalek alalek mentioned this pull request Jan 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin mshabunin approved these changes

Assignees

@mshabunin mshabunin

Labels

category: build/install category: videoio

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@asmorkalov @alalek @mshabunin @opencv-pushbot