Skip to content

DNN: let MatMul can work when both two inputs are const#22873

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
WanliZhong:issue22859
Nov 28, 2022
Merged

DNN: let MatMul can work when both two inputs are const#22873
opencv-pushbot merged 1 commit intoopencv:4.xfrom
WanliZhong:issue22859

Conversation

@WanliZhong
Copy link
Copy Markdown
Member

@WanliZhong WanliZhong commented Nov 27, 2022 •
edited
Loading

Merge with extra: opencv/opencv_extra#1021

This PR is try to solve the MatMul node problem of #22859

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@WanliZhong WanliZhong mentioned this pull request Nov 27, 2022
Merged
@WanliZhong WanliZhong requested a review from rogday November 27, 2022 10:53
rogday
rogday approved these changes Nov 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@opencv-pushbot opencv-pushbot merged commit 25ac77e into opencv:4.x Nov 28, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
@WanliZhong WanliZhong deleted the issue22859 branch May 16, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rogday rogday rogday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rogday rogday

Labels

category: dnn (onnx) ONNX suport issues in DNN module category: dnn feature test

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

OpenCV cannot import ONNX model: constBlobs.find(node_proto.input(0)) == constBlobs.end()

4 participants

@WanliZhong @rogday @opencv-pushbot @alalek