Skip to content

Fixed OpenGL errors formatting#22866

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
asmorkalov:as/error_formatting
Nov 25, 2022
Merged

Fixed OpenGL errors formatting#22866
opencv-pushbot merged 1 commit intoopencv:4.xfrom
asmorkalov:as/error_formatting

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Nov 25, 2022 •
edited by alalek
Loading

Fix for #22855

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
build_image:Custom=qt:16.04
buildworker:Custom=linux-1

@asmorkalov asmorkalov added this to the 4.7.0 milestone Nov 25, 2022
@asmorkalov asmorkalov requested a review from alalek November 25, 2022 13:47
@opencv-pushbot opencv-pushbot merged commit bc6544c into opencv:4.x Nov 25, 2022
alalek
alalek reviewed Nov 26, 2022
View reviewed changes
modules/core/src/opengl.cpp
cl_mem clBuffer = clCreateFromGLBuffer(context, clAccessFlags, buffer.bufId(), &status);
if (status != CL_SUCCESS)
CV_Error(cv::Error::OpenCLApiCallError, "OpenCL: clCreateFromGLBuffer failed: %d ", status);
CV_Error(cv::Error::OpenCLApiCallError, ("OpenCL: clCreateFromGLBuffer failed: %d", status));
Copy link
Copy Markdown
Member

@alalek alalek Nov 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CV_Error => CV_Error_

/build/master_etc-qt-openmp-lin64/opencv/modules/core/src/opengl.cpp:1886:93: warning: left operand of comma operator has no effect [-Wunused-value]
         CV_Error(cv::Error::OpenCLApiCallError, ("OpenCL: clCreateFromGLBuffer failed: %d", status));

here and below

@asmorkalov asmorkalov mentioned this pull request Nov 28, 2022
Merged
6 tasks
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: core

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asmorkalov @alalek @opencv-pushbot