Skip to content

dnn: support ONNX Tile#22809

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
fengyuentau:tile
Nov 29, 2022
Merged

dnn: support ONNX Tile#22809
asmorkalov merged 1 commit intoopencv:4.xfrom
fengyuentau:tile

Conversation

@fengyuentau
Copy link
Copy Markdown
Member

@fengyuentau fengyuentau commented Nov 15, 2022 •
edited
Loading

Fixes #22789

Merge with opencv/opencv_extra#1017

ONNX doc for Tile:

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@fengyuentau fengyuentau added feature category: dnn (onnx) ONNX suport issues in DNN module labels Nov 15, 2022
@fengyuentau fengyuentau added this to the 4.7.0 milestone Nov 15, 2022
@fengyuentau fengyuentau requested a review from rogday November 15, 2022 06:35
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Nov 15, 2022

@fengyuentau Thanks for the contribution! Could you enable related "conformance" tests too?

@fengyuentau
Copy link
Copy Markdown
Member Author

fengyuentau commented Nov 15, 2022 •
edited
Loading

Could you enable related "conformance" tests too?

Actually we cannot. This implementation requires one of the input (called repeats) being constant in order to determine the output shape. However, none of the conformance tests of tile have constant repeats, so I had to construct my own and put it in opencv_extra.

@alalek alalek mentioned this pull request Nov 17, 2022
Closed
4 tasks
rogday
rogday reviewed Nov 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

rogday
rogday approved these changes Nov 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@asmorkalov asmorkalov merged commit 421ba87 into opencv:4.x Nov 29, 2022
@fengyuentau fengyuentau deleted the tile branch November 29, 2022 11:47
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
@fengyuentau fengyuentau mentioned this pull request Mar 14, 2023
Open
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpisarev vpisarev vpisarev approved these changes

+1 more reviewer

@rogday rogday rogday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: dnn (onnx) ONNX suport issues in DNN module category: dnn feature

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

OpenCV cannot import ONNX model: Can't create layer "..." of type "Tile"

5 participants

@fengyuentau @asmorkalov @vpisarev @rogday @alalek