Fix #22767: Ensure that the buttons are spaced to the size of the toolbar window, which is always visible.#22806
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Nov 21, 2022
Conversation
AleksandrPanov
requested changes
Nov 17, 2022
Contributor
AleksandrPanov
left a comment
There was a problem hiding this comment.
Checked, the problem is reproduced, PR fixes the problem. Issue affects to 3.4, need to make a fix in 3.4
before fix:
after fix:
Member
|
This patch should go into 3.4 branch first. Please:
Note: no needs to re-open PR, apply changes "inplace". |
Contributor
Author
|
Sounds good. I'm on the road for couple more days, I'll have a look at it over the weekend. |
…he toolbar window, which is always visible. (rebased to 3.x)
3fc5587 to
e9d64e0
Compare
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #22767
This fixes some of the problems -- when toolbars are created in one go, and some go outside the window bounds (when main client are becomes nothing), they will get sized correctly.
However, with
WINDOW_NORMAL, some wonkiness still remains and blank buttons tend to appear once in a while (this might be due to the spacers).Ideally, the trackbars should automatically resize to fit the width of the main window, when said window is resized (either manually when in
NORMALmode, or by code). This might however break some existing code that relies on current behaviour to place multiple trackbars on single row. Any opinions?