Skip to content

define the number of dstChannels for HLS and HSV conversion as well#22771

Merged
asmorkalov merged 1 commit intoopencv:3.4from
kallaballa:opencl_hls_and_hsv_conversions_bug
Nov 17, 2022
Merged

define the number of dstChannels for HLS and HSV conversion as well#22771
asmorkalov merged 1 commit intoopencv:3.4from
kallaballa:opencl_hls_and_hsv_conversions_bug

Conversation

@kallaballa
Copy link
Copy Markdown
Contributor

@kallaballa kallaballa commented Nov 9, 2022

Pertaining Issue: #22770

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Copy Markdown
Member

alalek commented Nov 11, 2022

As a bugfix this patch should go into 3.4 branch first.
We will merge changes from 3.4 into 4.x regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: 4.x => 3.4 (use "Edit" button near PR title)
  • rebase your commits from 4.x onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/4.x
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@kallaballa
Copy link
Copy Markdown
Contributor Author

kallaballa commented Nov 11, 2022

Alright. I am on it

@kallaballa kallaballa changed the base branch from 4.x to 3.4 November 11, 2022 08:20
@kallaballa kallaballa force-pushed the opencl_hls_and_hsv_conversions_bug branch from 32c2623 to f5e852c Compare November 11, 2022 08:25
@kallaballa
Copy link
Copy Markdown
Contributor Author

kallaballa commented Nov 11, 2022 •
edited
Loading

Done f5e852c

@asmorkalov asmorkalov self-requested a review November 17, 2022 10:35
@asmorkalov asmorkalov merged commit 7592d58 into opencv:3.4 Nov 17, 2022
@alalek alalek mentioned this pull request Dec 3, 2022
Merged
@alalek alalek mentioned this pull request Dec 13, 2022
Closed
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

No one assigned

Labels

affected: 3.4 bug category: imgproc

Projects

None yet

Milestone

3.4.19

Development

Successfully merging this pull request may close these issues.

3 participants

@kallaballa @alalek @asmorkalov