Skip to content

improve code style and Doc of stackblur#22718

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
zihaomu:improve_stackblur
Oct 31, 2022
Merged

improve code style and Doc of stackblur#22718
opencv-pushbot merged 1 commit intoopencv:4.xfrom
zihaomu:improve_stackblur

Conversation

@zihaomu
Copy link
Copy Markdown
Member

@zihaomu zihaomu commented Oct 29, 2022 •
edited
Loading

Related comments: #20379 (comment)

Purpose of this PR:

  1. Remove the C-style implementation
  2. Improve API documentation of stackBlur.
  3. Remove inappropriate optimizations.
  4. Remove never used code.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@zihaomu zihaomu requested a review from alalek October 29, 2022 09:29
alalek
alalek approved these changes Oct 31, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 540aa13 into opencv:4.x Oct 31, 2022
@zihaomu zihaomu deleted the improve_stackblur branch November 6, 2022 01:53
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
@zhongxiangrong
Copy link
Copy Markdown

zhongxiangrong commented Dec 14, 2023

Why does C++'s stackblur run very slowly the first time and run very fast afterwards?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: imgproc

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@zihaomu @zhongxiangrong @alalek @opencv-pushbot