docs: remove duplicated step in Build .js doc#22672
Merged
alalek merged 2 commits intoopencv:4.xfrom Oct 21, 2022
Merged
Conversation
alalek
reviewed
Oct 21, 2022
| python ./platforms/js/build_js.py build_js --cmake_option="-DOPENCV_EXTRA_MODULES_PATH=opencv_contrib/modules" | ||
| @endcode | ||
|
|
||
| -# [optional] To enable OpenCV contrib modules append `--cmake_option="-DOPENCV_EXTRA_MODULES_PATH=/path/to/opencv_contrib/modules/"` |
Member
There was a problem hiding this comment.
Contributor
Author
|
@alalek this bug is also present in v5 https://docs.opencv.org/5.x/d4/da1/tutorial_js_setup.html, should I create a new pr for the 5.x branch? |
alalek
approved these changes
Oct 21, 2022
Member
alalek
left a comment
There was a problem hiding this comment.
Thank you 👍
Changes will be propagated to 5.x branch automatically: https://github.com/opencv/opencv/wiki/Branches
Separate patch is not needed.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicated step in Build OpenCV.js doc: https://docs.opencv.org/4.6.0/d4/da1/tutorial_js_setup.html
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.